New release 0.3.1#18
Merged
Merged
Conversation
=== Breaking changes - N/A === New features - N/A === Bug fixes - Add license file. (d37a398) Signed-off-by: Gris Ge <cnfourt@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request bumps the version to 0.3.1 and updates the changelog to reflect the addition of a license file. A review comment identifies a discrepancy between the content of the newly added license file and the license field in Cargo.toml, noting that the file contains a custom clause and lacks a standard copyright notice.
| - N/A | ||
|
|
||
| ### Bug fixes | ||
| - Add license file. (d37a398) |
There was a problem hiding this comment.
The LICENSE-MIT file being added contains a custom clause (lines 11-17) that is not part of the standard MIT license. This creates a discrepancy with the license = "MIT" field in Cargo.toml. Furthermore, the license file is missing the standard copyright notice line at the top.
To resolve this:
- If you want to use the standard MIT license, replace the file content with the standard MIT template (including a copyright line) and remove the custom clause.
- If the custom clause is intentional, update the
licensefield inCargo.tomltolicense-file = "LICENSE-MIT"to correctly reflect the use of a non-standard license.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
=== Breaking changes
=== New features
=== Bug fixes