Add a way to specify the interface on a get requests#37
Merged
Conversation
Sh3Rm4n
marked this pull request as draft
July 10, 2025 13:36
Sh3Rm4n
marked this pull request as ready for review
July 10, 2025 13:40
cathay4t
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tries to keep it consistent with the
setfunction also taking plainattributes.But it seems strange to set
Vec::new()when all interface attributes are requested. Also distinguishing aNLM_F_DUMPrequest depending if the attributes are empty or not shows the weakness of the approach.This should act as a basis for discussion up to this point.