Skip to content

Make Nl80211Rate a public type#68

Merged
cathay4t merged 2 commits into
rust-netlink:mainfrom
Sh3Rm4n:feat/public-rate
May 15, 2026
Merged

Make Nl80211Rate a public type#68
cathay4t merged 2 commits into
rust-netlink:mainfrom
Sh3Rm4n:feat/public-rate

Conversation

@Sh3Rm4n

@Sh3Rm4n Sh3Rm4n commented Mar 11, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@Sh3Rm4n
Sh3Rm4n requested a review from cathay4t March 11, 2026 15:07
@Sh3Rm4n Sh3Rm4n self-assigned this Mar 11, 2026
@Sh3Rm4n Sh3Rm4n changed the title Make Nl80211 a public type Make Nl80211Rate a public type Mar 11, 2026
@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the API of the library by exposing the Nl80211Rate type. This change allows consumers of the library to directly interact with and utilize rate information, improving the flexibility and utility of the networking-related functionalities.

Highlights

  • Type Visibility: The Nl80211Rate type has been made publicly accessible, allowing external modules to use it.
Changelog
  • src/lib.rs
    • Exported Nl80211Rate from the wiphy module.
  • src/wiphy/mod.rs
    • Exported Nl80211Rate from the band module.
Activity
  • No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request re-exports the Nl80211Rate type to make it part of the public API. The changes involve adding Nl80211Rate to pub use statements in src/lib.rs and src/wiphy/mod.rs. The code has been reviewed and no issues were found.

@cathay4t
cathay4t force-pushed the feat/public-rate branch from a7c3b53 to 8a447d9 Compare May 15, 2026 11:49
@cathay4t
cathay4t enabled auto-merge (rebase) May 15, 2026 11:49
@cathay4t
cathay4t merged commit 6e5c6d7 into rust-netlink:main May 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants