Skip to content

test: Move element test to unified folder#78

Merged
cathay4t merged 1 commit into
rust-netlink:mainfrom
cathay4t:main
Jun 21, 2026
Merged

test: Move element test to unified folder#78
cathay4t merged 1 commit into
rust-netlink:mainfrom
cathay4t:main

Conversation

@cathay4t

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Gris Ge <cnfourt@gmail.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request moves the element tests from src/element.rs to a unified src/tests/ directory. However, this change introduces compilation errors because the new test module is not declared in src/tests/mod.rs and the imports in the moved test file still use super instead of referencing the correct crate paths.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

I am having trouble creating individual review comments. Click here to see my feedback.

src/element.rs (12-13)

high

Moving the element tests to the unified src/tests/ directory introduces two issues that will prevent the tests from compiling and running:

  1. Missing Module Declaration: The new test file src/tests/element.rs is not declared in src/tests/mod.rs. You need to add mod element; to src/tests/mod.rs so that the tests are compiled and executed.
  2. Broken Imports: In src/tests/element.rs, the imports use use super::{...}. Previously, super referred to crate::element where these types are defined. Now that the file is under crate::tests, super refers to crate::tests, which does not contain these types. You should update the imports in src/tests/element.rs to use use crate::{...} instead.

@cathay4t
cathay4t merged commit c51edbc into rust-netlink:main Jun 21, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant