Open
Conversation
Zane-Liao
reviewed
Mar 9, 2025
Zane-Liao
left a comment
Zane-Liao
left a comment
There was a problem hiding this comment.
I think belated code review is also review, we need to make this project active again.
|
The Comments are pretty good ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the
clangdependency for theritualcrate from 0.20.0 to 1.0(.3). This fixes an issue for me on Gentoo where the older version ofclang-systhatclangdepends on, where it tries to use/usr/lib/llvm/12/lib/libclang.so(the 32-bit version) rather than/usr/lib/llvm/12/lib64/libclang.so(the 64-bit version). On distributions other than Ubuntu and Debian, the 64-bit versions of libraries may be located in/usr/lib64or a similarly namedlib64directory.