chore: move rust-vmm deps to workspace dependencies#942
chore: move rust-vmm deps to workspace dependencies#942hanbings wants to merge 1 commit intorust-vmm:mainfrom
Conversation
|
We like to have all the information in the git history and usually PR description will not be part of that, so please avoid commit with empty description, and especially add the reason why we are doing that. For example in this case one of the reason is to have a single place for the entire workspace where we can handle versions of rust-vmm dependencies. |
stefano-garzarella
left a comment
There was a problem hiding this comment.
Should we cover also crates in staging/ ?
That makes sense. Should I use rebase to update the commit message? |
Yes, rebase and force push. Our policy is to avoid any fixup in a PR (e.g. no new commits to fix code added by commits in the same PR), so it's perfectly fine to rebase the PR, update commits (code or description/title) and force push. |
Thank you for the review. I have made the changes in the latest commit. |
RuoqingHe
left a comment
There was a problem hiding this comment.
Code-wise looking good, it would be better if you could put the "sorting and formatting" changes into a separate commit, and use taplo to format it
Move rust-vmm deps to workspace level for unified management - Migrate rust-vmm related dependencies (e.g. vhost, vm-memory) to workspace-level Cargo.toml for centralized version control - Sub-crates under the staging/ are still managed by the Cargo.toml within staging/, while also declaring the dependencies at the workspace level Signed-off-by: hanbings <hanbings@hanbings.io>
Thank you for the review! I'll address the sorting/formatting changes with taplo in a separate follow-up PR. |
I've added workspace dependencies in |
Summary of the PR
This PR moves rust-vmm related dependencies to workspace dependencies, and alphabetically reorders some of the crate declarations.
Closes #906
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.