vhost-device-gpu: Implement RESOURCE_ASSIGN_UUID command#945
Open
dorindabassey wants to merge 1 commit intorust-vmm:mainfrom
Open
vhost-device-gpu: Implement RESOURCE_ASSIGN_UUID command#945dorindabassey wants to merge 1 commit intorust-vmm:mainfrom
dorindabassey wants to merge 1 commit intorust-vmm:mainfrom
Conversation
dorindabassey
requested review from
epilys,
stefano-garzarella,
stsquad and
vireshk
as code owners
Add support for the VIRTIO_GPU_CMD_RESOURCE_ASSIGN_UUID command, allowing guests to query UUIDs for GPU resources. This commit adds VIRTIO_GPU_F_RESOURCE_UUID feature flag, routes ResourceAssignUuid commands to renderer backend and adds tests for UUID command processing and generation. Signed-off-by: Dorinda Bassey <dbassey@redhat.com>
dorindabassey
force-pushed
the
assign_uuid
branch
from
a3f24b7 to
09248e2
Compare
epilys
reviewed
Mar 20, 2026
Member
There was a problem hiding this comment.
LGTM @dorindabassey
However, shouldn't we check if the VIRTIO_GPU_F_RESOURCE_UUID feature bit is negotiated before replying to a VIRTIO_GPU_CMD_RESOURCE_ASSIGN_UUID command?
(You can implement VhostUserBackendMut::acked_features)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Add support for the VIRTIO_GPU_CMD_RESOURCE_ASSIGN_UUID command, allowing guests to query UUIDs for GPU resources. This commit adds VIRTIO_GPU_F_RESOURCE_UUID feature flag, routes ResourceAssignUuid commands to renderer backend and adds tests for UUID command processing and generation.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.