make crate no_std compatible#530
Open
fschutt wants to merge 3 commits into
Open
Conversation
Author
|
For some reason this doesn't build but that's not because of my code, but because of an error in the updated khronos bindings |
This was referenced Feb 6, 2021
|
as a side note: |
MarijnS95
force-pushed
the
master
branch
3 times, most recently
from
69d0fb1 to
a4140fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the groundwork for making
gleamno_std compatible. I needgleamto be no_std so I can use theRc<dyn Gl>in no_std crates without having to depend on the standard library.All the "OS dependent" things that gleam uses are type definitions and it's not really necessary to depend on the standard library for that. This PR uses code from the cty crate, adjusted for the GL purpose.
It also changes
c_chartoc_uchar(which doesn't change the ABI, but it does clarify the usage becauseunsigned charandsigned charare not always the same in C).