Skip to content

Update MSRV to 1.81 #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

waywardmonkeys
Copy link
Contributor

@waywardmonkeys waywardmonkeys commented Mar 23, 2025

This also changes to use the derived Default for enums since that is available with a later MSRV (and would otherwise have clippy warnings).

Updating the MSRV allows the no_std support to be slightly better by allowing core::error::Error to be impl'd for the error types.

@waywardmonkeys
Copy link
Contributor Author

@madsmtm Even if we don't do this bump now ... I could update the MSRV here to 1.73 (matching winit) which would let us keep these Default changes, but also letting CI run slightly faster by not needing to do a build without the sparse registries in Cargo (stabilized in Rust 1.68, IIRC).

@pyfisch
Copy link
Contributor

pyfisch commented Apr 21, 2025

@madsmtm Either we bump the MSRV to 1.81 before the v0.8 release or it stays on 1.61 for a long time as this crate doesn't have too many releases.

This also changes to use the derived `Default` for enums since
that is available with a later MSRV (and would otherwise have
clippy warnings).

Updating the MSRV allows the `no_std` support to be slightly
better by allowing `core::error::Error` to be impl'd for the
error types.
@waywardmonkeys
Copy link
Contributor Author

I've updated this now that no_std has landed so that the workaround for core::error::Error is addressed. If this lands, then I'll have one more follow up on the no_std stuff to make it a bit better.

Copy link
Member

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to not update MSRV.

Like I said in #17, I'd rather have two MSRVs, one for no_std, and one for std (see #75). Or just one MSRV, and then not have the Error impl in no_std (as is currently implemented).

@pyfisch pyfisch closed this Apr 27, 2025
@waywardmonkeys waywardmonkeys deleted the msrv-bump branch April 29, 2025 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants