Fix typo, check in CI going forward #71
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pins a version of the typos check which means someone would need to periodically update it. That prevents people from having to fix typos unrelated to their changes, should there be new things found by a future update of the typos check.
madsmtm
approved these changes
Mar 27, 2025
| [files] | ||
| # Include .github, .cargo, etc. | ||
| ignore-hidden = false | ||
| extend-exclude = [ |
There was a problem hiding this comment.
Should probably include src/code.rs and src/named_key.rs, since those are auto-generated and mostly outside our control.
Comment on lines
+19
to
+21
| # /.git isn't in .gitignore, because git never tracks it. | ||
| # Typos doesn't know that, though. | ||
| "/.git", |
There was a problem hiding this comment.
Sounds like a bug in typos? Do you know if there is one?
|
Looks fine to me (with comments resolved) |
|
I fixed the typo in main. However I think it is not necessary to check for typos continuously and incur the maintenance overhead for another CI job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pins a version of the typos check which means someone would need to periodically update it. That prevents people from having to fix typos unrelated to their changes, should there be new things found by a future update of the typos check.