Skip to content

Conversation

@felix91gr
Copy link
Collaborator

CC @PLeVasseur I'm syncing the spec lock file again to upstream; #132 and #136 can't currently build because of it x3

I think I did it alright? Lmk if I should change anything

@felix91gr felix91gr requested a review from PLeVasseur August 11, 2025 20:06
@netlify
Copy link

netlify bot commented Aug 11, 2025

Deploy Preview for scrc-coding-guidelines ready!

Name Link
🔨 Latest commit 2cd7f4b
🔍 Latest deploy log https://app.netlify.com/projects/scrc-coding-guidelines/deploys/689a4d2d07130900088c2bcc
😎 Deploy Preview https://deploy-preview-172--scrc-coding-guidelines.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@PLeVasseur
Copy link
Contributor

Hey @felix91gr -- thanks for this.

Wanted to check to make sure you've seen this note with steps to confirm that there's no impact from the FLS change to the coding guidelines.

Had you seen it? Did you run through this process this time?

@felix91gr
Copy link
Collaborator Author

@PLeVasseur I used the output of https://github.com/rustfoundation/safety-critical-rust-coding-guidelines/actions/runs/16881087242/job/47816848850?pr=136#step:4:187 as a reference. It requires changes to 0 guidelines, so I assumed it would be okay to just run the command of step 6.

Though lemme just quickly check that main alone also gives that output. It might be the case that another change to the FLS has happened in the meantime which the Build process in CI hasn't seen yet.

@felix91gr
Copy link
Collaborator Author

Yep, should be good. A quick clone of the repo gives me the build error with 0 guidelines needing changes :)

Copy link
Contributor

@PLeVasseur PLeVasseur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @felix91gr!

@PLeVasseur PLeVasseur added this pull request to the merge queue Aug 11, 2025
Merged via the queue into main with commit 1d5d163 Aug 11, 2025
6 checks passed
@felix91gr felix91gr deleted the felix91gr_bump_spec_lock_file branch August 11, 2025 20:38
@felix91gr
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants