Skip to content

Conversation

@PLeVasseur
Copy link
Contributor

Example of update to remove verbosity:

    Please manually inspect FLS spec items whose checksums have changed as corresponding guidelines may need to account for these changes.
    Once resolved, you may run the following to update the local spec lock file:
    	./make.py --update-spec-lock-file

... snip ...

Error: Build errors detected in log
=== ERROR DETAILS ===
=== TRACEBACK ===
Saving traceback to build/sphinx_traceback.log
=== SPEC LOCK FILE DIFFERENCES ===
Saving spec lock file differences to to build/spec_lock_file_differences.log
Error: Process completed with exit code 1.

closes #28

* Add summary on affected guidelines

* Make FLS differences output even if affecting no guidelines. Pull this into the archive.
@plaindocs
Copy link
Collaborator

This is helpful.

Can we have an entry in the readme and a link in the error message of either how to update the spec file, or ideally, how to ignore it for WIP builds?

@PLeVasseur
Copy link
Contributor Author

PLeVasseur commented Apr 9, 2025

Thanks @plaindocs for the suggestions. It does seem useful to mention this in the README as it's likely to happen fairly often.

Good idea on a way to silence this error if working on something. I'll give it some thought.

@PLeVasseur PLeVasseur force-pushed the feature/make-spec-update-clearer branch from aed072d to ceb3ece Compare April 12, 2025 16:06
@PLeVasseur PLeVasseur force-pushed the feature/make-spec-update-clearer branch from 42e8eb7 to 6a15df1 Compare April 12, 2025 16:11
@PLeVasseur
Copy link
Contributor Author

Hey @plaindocs -- I think I've addressed the ideas you brought up. Can you give it a look?

Copy link
Collaborator

@plaindocs plaindocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. 👍

@PLeVasseur
Copy link
Contributor Author

Gonna merge this one -- thanks @plaindocs for the suggestions to improve it!

@PLeVasseur PLeVasseur merged commit 5a99ee7 into rustfoundation:main Apr 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update spec lock file

2 participants