docs: clarify guideline PR-to-merge flow#421
Open
PLeVasseur wants to merge 3 commits intorustfoundation:mainfrom
Open
docs: clarify guideline PR-to-merge flow#421PLeVasseur wants to merge 3 commits intorustfoundation:mainfrom
PLeVasseur wants to merge 3 commits intorustfoundation:mainfrom
Conversation
✅ Deploy Preview for scrc-coding-guidelines ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
plaindocs
approved these changes
Mar 3, 2026
Collaborator
plaindocs
left a comment
plaindocs
left a comment
There was a problem hiding this comment.
Like it, despite the merge headache I'm setting myself up for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sign-off: create pris clearly distinguished from PR approval and merge queueing.REVIEWING.mdfor running@guidelines-bot /label +sign-off: create pr, and clarify that contributors open their own PRs.closes #<issue>guidance.Validation
uv run ruff check --fix scripts/reviewer_bot.py .github/reviewer-bot-tests/test_reviewer_bot.pyuv run pytest .github/reviewer-bot-tests/test_reviewer_bot.pyIssues
Closes #413
Closes #412