Skip to content

fix(reviewer-bot): infer pr observer context correctly#535

Merged
PLeVasseur merged 1 commit intorustfoundation:mainfrom
PLeVasseur:fix/reviewer-bot-pr-observer-pr-context
Mar 20, 2026
Merged

fix(reviewer-bot): infer pr observer context correctly#535
PLeVasseur merged 1 commit intorustfoundation:mainfrom
PLeVasseur:fix/reviewer-bot-pr-observer-pr-context

Conversation

@PLeVasseur
Copy link
Copy Markdown
Collaborator

Summary

  • make the PR observer payload builder use a PR-specific classifier that does not depend on IS_PULL_REQUEST being set in the observer workflow environment
  • keep the issue-vs-PR split in the main comment router while ensuring trusted-direct same-repo human PR comments produce observer_noop payloads in observer builds
  • update the regression test so it proves the trusted-direct observer noop works without ambient PR context env hacks

Testing

  • uv run python -m pytest .github/reviewer-bot-tests/test_reviewer_bot.py .github/reviewer-bot-tests/test_main.py

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 20, 2026

Deploy Preview for scrc-coding-guidelines ready!

Name Link
🔨 Latest commit 31ec1ad
🔍 Latest deploy log https://app.netlify.com/projects/scrc-coding-guidelines/deploys/69bdbaf02923be000806e6cf
😎 Deploy Preview https://deploy-preview-535--scrc-coding-guidelines.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@PLeVasseur PLeVasseur merged commit 35cecf0 into rustfoundation:main Mar 20, 2026
16 checks passed
@PLeVasseur PLeVasseur deleted the fix/reviewer-bot-pr-observer-pr-context branch March 20, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant