Skip to content

fix(reviewer-bot): unify pr assignment guidance#537

Merged
PLeVasseur merged 1 commit intorustfoundation:mainfrom
PLeVasseur:fix/reviewer-bot-pr-guidance-consistency
Mar 20, 2026
Merged

fix(reviewer-bot): unify pr assignment guidance#537
PLeVasseur merged 1 commit intorustfoundation:mainfrom
PLeVasseur:fix/reviewer-bot-pr-guidance-consistency

Conversation

@PLeVasseur
Copy link
Copy Markdown
Collaborator

Summary

  • centralize reviewer assignment side effects in the command path so successful PR reviewer changes consistently post PR guidance for /r? @user, /claim, /pass, and reassignment after /away
  • keep assignment failure comments and reviewer state updates aligned across the PR reviewer-changing command family instead of duplicating slightly different logic in each handler
  • add regression tests covering explicit assignment, claim, pass, and queue-based assignment guidance behavior on PRs

Testing

  • uv run ruff check --fix scripts/reviewer_bot_lib/commands.py .github/reviewer-bot-tests/test_reviewer_bot.py
  • uv run python -m pytest .github/reviewer-bot-tests/test_reviewer_bot.py .github/reviewer-bot-tests/test_main.py

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 20, 2026

Deploy Preview for scrc-coding-guidelines ready!

Name Link
🔨 Latest commit 7215fee
🔍 Latest deploy log https://app.netlify.com/projects/scrc-coding-guidelines/deploys/69bdc3aae73cda0008577fd4
😎 Deploy Preview https://deploy-preview-537--scrc-coding-guidelines.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@PLeVasseur PLeVasseur merged commit 694412b into rustfoundation:main Mar 20, 2026
16 checks passed
@PLeVasseur PLeVasseur deleted the fix/reviewer-bot-pr-guidance-consistency branch March 20, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant