Skip to content

fix(reviewer-bot): harden GitHub API failure handling#546

Open
PLeVasseur wants to merge 62 commits intorustfoundation:mainfrom
PLeVasseur:reviewer-bot-github-api-robustness-2026-03-31
Open

fix(reviewer-bot): harden GitHub API failure handling#546
PLeVasseur wants to merge 62 commits intorustfoundation:mainfrom
PLeVasseur:reviewer-bot-github-api-robustness-2026-03-31

Conversation

@PLeVasseur
Copy link
Copy Markdown
Collaborator

Summary

  • extend reviewer-bot GitHub transport results with classified failure metadata and explicit idempotent-read retry policy
  • harden maintenance, reviews, sweeper, reconcile, state store, lease lock, and command paths so transient GitHub read failures either record truthful diagnostics or fail closed at correctness boundaries
  • fix helper correctness traps around permission tri-state, assignee availability, label removal, overdue warning state writes, state issue If-Match handling, and duplicate-PR prevention

Testing

  • ran targeted reviewer-bot tests after each implementation phase gate
  • ran uv run ruff check --fix scripts/reviewer_bot.py scripts/reviewer_bot_lib .github/reviewer-bot-tests/test_reviewer_bot.py
  • ran uv run pytest .github/reviewer-bot-tests/test_reviewer_bot.py

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 30, 2026

Deploy Preview for scrc-coding-guidelines ready!

Name Link
🔨 Latest commit 8608641
🔍 Latest deploy log https://app.netlify.com/projects/scrc-coding-guidelines/deploys/69cd68c2b8ce1b0008ba7df1
😎 Deploy Preview https://deploy-preview-546--scrc-coding-guidelines.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant