Skip to content

fix:ensure Name precedes Contents in ListObjectsOutput XML#1

Merged
loverustfs merged 1 commit intorustfs:mainfrom
LeonWang0735:fix/correctly-handle-order-of-ListObjectOutput
Feb 5, 2026
Merged

fix:ensure Name precedes Contents in ListObjectsOutput XML#1
loverustfs merged 1 commit intorustfs:mainfrom
LeonWang0735:fix/correctly-handle-order-of-ListObjectOutput

Conversation

@LeonWang0735
Copy link

Summary of the Changes

ensure Name precedes Contents in ListObjectsOutput XML

Related Issue

rustfs/rustfs#1728

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the XML element ordering in ListObjectsOutput and ListObjectsV2Output to ensure the Name element precedes Contents in the XML response, addressing compatibility issues with S3 clients that expect a specific field order.

Changes:

  • Added a new order.rs module in the codegen to define custom field ordering for specific output structures
  • Updated the code generation logic in dto.rs to apply custom field ordering when specified
  • Regenerated all affected files with the correct field order

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
codegen/src/v1/order.rs New module defining field order for ListObjectsOutput and ListObjectsV2Output
codegen/src/v1/mod.rs Added order module declaration
codegen/src/v1/dto.rs Updated struct generation logic to apply custom field ordering
crates/s3s/src/xml/generated.rs Regenerated XML serialization with correct field order
crates/s3s/src/xml/generated_minio.rs Regenerated XML serialization with correct field order (MinIO variant)
crates/s3s/src/dto/generated.rs Regenerated struct definitions, Debug impls, and DtoExt impls with correct field order
crates/s3s/src/dto/generated_minio.rs Regenerated struct definitions, Debug impls, and DtoExt impls with correct field order (MinIO variant)
crates/s3s-aws/src/conv/generated.rs Regenerated AWS conversion code with correct field order
crates/s3s-aws/src/conv/generated_minio.rs Regenerated AWS conversion code with correct field order (MinIO variant)

@codecov
Copy link

codecov bot commented Feb 5, 2026

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

@loverustfs loverustfs merged commit 7925449 into rustfs:main Feb 5, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants