fix:ensure Name precedes Contents in ListObjectsOutput XML#1
Merged
loverustfs merged 1 commit intorustfs:mainfrom Feb 5, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the XML element ordering in ListObjectsOutput and ListObjectsV2Output to ensure the Name element precedes Contents in the XML response, addressing compatibility issues with S3 clients that expect a specific field order.
Changes:
- Added a new
order.rsmodule in the codegen to define custom field ordering for specific output structures - Updated the code generation logic in
dto.rsto apply custom field ordering when specified - Regenerated all affected files with the correct field order
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| codegen/src/v1/order.rs | New module defining field order for ListObjectsOutput and ListObjectsV2Output |
| codegen/src/v1/mod.rs | Added order module declaration |
| codegen/src/v1/dto.rs | Updated struct generation logic to apply custom field ordering |
| crates/s3s/src/xml/generated.rs | Regenerated XML serialization with correct field order |
| crates/s3s/src/xml/generated_minio.rs | Regenerated XML serialization with correct field order (MinIO variant) |
| crates/s3s/src/dto/generated.rs | Regenerated struct definitions, Debug impls, and DtoExt impls with correct field order |
| crates/s3s/src/dto/generated_minio.rs | Regenerated struct definitions, Debug impls, and DtoExt impls with correct field order (MinIO variant) |
| crates/s3s-aws/src/conv/generated.rs | Regenerated AWS conversion code with correct field order |
| crates/s3s-aws/src/conv/generated_minio.rs | Regenerated AWS conversion code with correct field order (MinIO variant) |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Changes
ensure Name precedes Contents in ListObjectsOutput XML
Related Issue
rustfs/rustfs#1728