Remove Buy sensors links from app UI#1541
Merged
ojousima merged 1 commit intomilestone/3.5from Mar 3, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Removes all in-app UI entry points that directed users to “Buy Ruuvi sensors”, aligning the app UI with issue #1532 by eliminating the drawer menu item and Add Sensor screen buttons, plus their URL click handlers.
Changes:
- Removed the “Buy Ruuvi sensors” item from the legacy (XML) main drawer menu.
- Removed the “Buy Ruuvi sensors” entry from the Compose dashboard drawer and its click handler.
- Removed “Buy Ruuvi sensors” buttons from the Add Sensor (Add Tag) screen and their associated click listeners.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/src/main/res/menu/menu_main.xml | Removes legacy drawer menu group/item for buying sensors. |
| app/src/main/res/layout/content_add_tag.xml | Removes buy-sensors buttons from the Add Sensor screen layout. |
| app/src/main/java/com/ruuvi/station/app/ui/MainMenu.kt | Removes Compose drawer menu item and URL-opening handler for buy sensors. |
| app/src/main/java/com/ruuvi/station/addtag/ui/AddTagActivity.kt | Removes visibility toggles, click listeners, and import related to buy-sensors buttons/URL. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1532
Summary
Review notes
scripts/ci/update_l10n.sh, so this PR intentionally avoids manual string-key deletions./gradlew :app:compileWithoutFileLogsDebugKotlin :app:mergeWithoutFileLogsDebugResources