Close #300: Add definition for new HTTP status code 206 (Partial Content) to enum http_resp_code_e#301
Close #300: Add definition for new HTTP status code 206 (Partial Content) to enum http_resp_code_e#301TheSomeMan merged 7 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request attempts to add support for HTTP status code 206 (Partial Content) to the WiFi manager's HTTP server implementation. The changes include adding the new status code to the enum definition and routing it through the existing response handling logic.
Changes:
- Added
HTTP_RESP_CODE_206enum value (206) to the HTTP response code enumeration - Added case statement to route HTTP 206 responses through the same handler as HTTP 200
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/include/wifi_manager_defs.h | Adds HTTP_RESP_CODE_206 enum value for partial content responses |
| src/http_server_accept_and_handle_conn.c | Adds switch case to handle HTTP 206 responses by falling through to the HTTP 200 handler |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…dling Introduces the HTTP 416 status code and a dedicated response function. The server now explicitly rejects requests for partial content (HTTP 206) by responding with 416, clarifying that range requests are not supported. Relates to #300
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TheSomeMan
changed the title
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Treats HTTP 206 (Partial Content) responses as HTTP 200 OK, as the server currently supports only HTTP/1.0. This prevents requests for partial content from being handled as service unavailable errors.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Explicitly sets HTTP 206 Partial Content responses to HTTP 200 OK due to the server's HTTP/1.0 limitation. Logs a warning when this fallback occurs and ensures the correct 200 handling logic is applied. Closes #300
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.