Add option to blend STHS debug data into acceleration for quick valid…#273
Open
Add option to blend STHS debug data into acceleration for quick valid…#273
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds a debug mode feature to the STHS34PF80 thermal infrared sensor driver that allows debug data to be reported through acceleration fields for easier validation and visualization. When enabled via the SHTS_DEBUG_DATA_IN_ACCELERATION flag, raw algorithm values are exposed as pseudo-acceleration data alongside the standard sensor readings.
Changes:
- Adds debug mode that exposes internal algorithm values (tpresence, tmotion, tobject) as acceleration fields for plotting/debugging
- Introduces temperature shock detection and automatic algorithm reset functionality
- Adds
ri_sths34pf80_configure_defaults()function with ST reference configuration values for thresholds and averaging - Extends sensor data structure with new
debug_tambfield for ambient shock monitoring
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
src/ruuvi_driver_sensor.h |
Adds debug_tamb field to sensor data bitfield and corresponding macro |
src/interfaces/environmental/ruuvi_interface_sths34pf80.h |
Adds default configuration constants and configure_defaults() function declaration |
src/interfaces/environmental/ruuvi_interface_sths34pf80.c |
Implements debug data blending, temperature shock handling, and default configuration function |
test/interfaces/environmental/test_ruuvi_interface_sths34pf80.c |
Adds test helpers and new test for data index validation |
src/integration_tests/ruuvi_driver_sensor_test.c |
Updates maximum field count and adds field name for printing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
test/interfaces/environmental/test_ruuvi_interface_sths34pf80.c
Outdated
Show resolved
Hide resolved
test/interfaces/environmental/test_ruuvi_interface_sths34pf80.c
Outdated
Show resolved
Hide resolved
test/interfaces/environmental/test_ruuvi_interface_sths34pf80.c
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Closes #274