Close #71: Add sha256_stub - RAM loaded firmware to calculate SHA256 hash of flashed firmware#72
Open
TheSomeMan wants to merge 1 commit intomasterfrom
Open
Close #71: Add sha256_stub - RAM loaded firmware to calculate SHA256 hash of flashed firmware#72TheSomeMan wants to merge 1 commit intomasterfrom
TheSomeMan wants to merge 1 commit intomasterfrom
Conversation
…hash of flashed firmware
|
ojousima
approved these changes
Dec 30, 2025
Member
ojousima
left a comment
ojousima
left a comment
There was a problem hiding this comment.
Beautiful implementation for verifying flash overall, great work.
Has the SHA256 algorithm been verified against any public test vectors? If not, would it be simple enough to add tests, as in less than a day of effort?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.