You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 23, 2021. It is now read-only.
The reason will be displayed to describe this comment to others. Learn more.
Maybe toggling LED on each page erase would be helpful especially with no LOG, DEV KIT and Link +JLinkRTTClient is active. Really important if button were to be long pressed by accident!
Does this really warrant version change from 2.5.9 to 2.6.0 rather than 2.5.10 ?
Maybe toggling LED on each page erase would be helpful especially with no LOG, DEV KIT and Link +JLinkRTTClient is active. Really important if button were to be long pressed by accident!
The erase takes 2 seconds, so led toggling doesn't add a lot of new information.
Does this really warrant version change from 2.5.9 to 2.6.0 rather than 2.5.10 ?
Yes, as it is adding a new functionality. 2.5.10 would be a bugfix in existing functionality.
Please add a comment in main.c (none since 2.5.6 last year)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix issue where Espruino won't boot when RuuviTag has old data in flash.