fix(storage): allow unauthenticated participants to upload media into storage for public tests (#2286) - #2302
Open
chirag-gupta-07 wants to merge 1 commit into
Conversation
… storage for public tests (ruxailab#2286)
|
Author
|
@KarinePistili Take a look at this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Resolves an issue where unauthenticated / anonymous participants could not upload screen, audio, or video recordings during public user tests due to restrictive Firebase Storage security rules and unconfigured storage initialization in media recorder components.
Problem
storage.rulesdid not allow unauthenticated access to the test upload paths (tests/{studyId}/{userId}/...) even when the test was configured as public (study.isPublic == true). This resulted in403 Forbidden(storage/unauthorized) errors when submitting recordings.ScreenRecorder.vue,AudioRecorder.vue,VideoRecorder.vue) were callinggetStorage()directly without configuration, causing requests to route to production Firebase Storage instead of the configured emulator, triggering CORS failures.ScreenRecorder.vuewas not generating a valid timestamped.webmfilename, causing upload path issues.Related Issue
Fixes #2286
Changes Made
storage.rules: Addedstudy(studyId).isPublic == truecheck tocanAnswerStudyandmatch /tests/{studyId}/{userId}/{allPaths=**}to allow unauthenticated read and upload access for public studies.ScreenRecorder.vue:storageinstance from@/app/plugins/firebase..webm(${Date.now()}.webm).AudioRecorder.vue&VideoRecorder.vue:storageinstance from@/app/plugins/firebase.How to Test
.webmfile is present in Firebase Storage.Video Proof
Part 1-
Part.1.mp4
Part 2-
Part.2.mp4