Fixed caching bug

[unartig]

I've made a mistake while renaming some data-objects last time.
Caching should work with this change again.

Summary by CodeRabbit

• Bug Fixes
  • Improved caching to ensure only sanitized and fully processed data is saved, rather than raw data.

[coderabbitai]

Walkthrough

The change updates the preprocess_data function in split_process_data.py to pass the processed and sanitized data to the caching function instead of the original raw data. This ensures that the cache now contains the fully preprocessed data rather than the initial unprocessed input.

Changes

File(s)	Change Summary
icu_benchmarks/data/split_process_data.py	Modified preprocess_data to cache sanitized data instead of raw data

Estimated code review effort

1 (~2 minutes)

Poem

In the cache where data sleeps,
Now only clean and tidy heaps.
No more raw and messy bits,
Just sanitized, perfect fits.
A bunny hops with joyful cheer,
For tidy data’s finally here! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 54a0420 and 7425f13.

📒 Files selected for processing (1)

• icu_benchmarks/data/split_process_data.py (1 hunks)

🧠 Learnings (1)

📓 Common learnings

Learnt from: rvandewater
PR: rvandewater/YAIB#155
File: icu_benchmarks/data/preprocessor.py:77-143
Timestamp: 2024-10-17T14:03:23.185Z
Learning: In the `apply` method of `PolarsClassificationPreprocessor` in `icu_benchmarks/data/preprocessor.py`, the data is pre-split, necessitating multiple join operations; thus, optimizing by combining joins is not feasible.

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: rvandewater
PR: rvandewater/YAIB#155
File: icu_benchmarks/data/preprocessor.py:77-143
Timestamp: 2024-10-17T14:03:23.185Z
Learning: In the `apply` method of `PolarsClassificationPreprocessor` in `icu_benchmarks/data/preprocessor.py`, the data is pre-split, necessitating multiple join operations; thus, optimizing by combining joins is not feasible.

🔇 Additional comments (1)

icu_benchmarks/data/split_process_data.py (1)

201-201: LGTM! This correctly fixes the caching logic.

Passing sanitized_data instead of data to the caching function ensures that the cache contains the fully processed data (sanitized, split, and preprocessed) rather than the raw loaded data. This maintains consistency between cached and non-cached execution paths.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.