Improve the handling of strings #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davydog187
reviewed
Jun 23, 2025
| {Cr,St2} = var_rest(Rest, St1), | ||
| {dot(L, Ce, Cr),St2}; | ||
| var({{'NAME',L,N},_Attrib}, St) -> | ||
| %% Fro now we ignore attributes. |
Collaborator
There was a problem hiding this comment.
Suggested change
| %% Fro now we ignore attributes. | |
| %% For now we ignore attributes. |
It is now correct and compatible.
Loading in a file should now result in bytes and not potential unicode codepoints.
Now it is only done in the \u{...} where it should be.
They are now accepted in the syntax of local variables but the compiler ignores them.
%s now checks for '0' in string when it should, though it handles other options in the C fashion.
These are now more compatible with the standard Lua ones. It will have to do until someone seriously requests more.
Owner
Author
|
Can leave luerl_comp_normalise.erl as it is because the next PR I add will fix parsing and do more in luerl_comp_normalise.erl |
Owner
Author
|
OK, if we are happy with this I will merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we fix the handling of strings in the
stringmodule. It behaves as it should but the formatting of some numerical output strings, while it is correct, does not quite look the same as the Lua module. This is because the Lua implementation uses C libraries while Luerl uses Erlang libraries.