Improve the scanner and fix the parser #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The scanner can now handle all the ways of writing literal decimal and hexadecimal numbers whicc can be a bit "strange". Also fix strings backquote characters.
The parser can now handle attributes though we ignore them. The normaliser now handles local functions by assigning them first so they can reference themselves in the body. This is defined by Lua.
rvirding
force-pushed
the
develop-scan-parse
branch
from
9acbda7 to
fee8313
Compare
This will probably be extended later. Also fix the compiler to use the new luerl_io module.
rvirding
force-pushed
the
develop-scan-parse
branch
from
b96e21a to
4788b53
Compare
We now follow Lua here. Also add some documentation about this in luerl.erl.
rvirding
force-pushed
the
develop-scan-parse
branch
from
50b59a6 to
9c7dffa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We fix the scanner so it handles numbers in a Lua compliant manner and signals errors in a compatible way. E.g. the sequence "12.3e4fgh" now generates and error whereas before it generated a number and a name. This is exactly what Lua does. We also make strings scan the same way.
The parser now handles attributes in local variables though we don't use this feature. Also we make sure that local functions can do recursive calls and also reference their own name in the function. Again to be Lua compliant.