Skip to content

ical - #20

Merged
rviscomi merged 2 commits into
mainfrom
ical
Jun 30, 2025
Merged

ical#20
rviscomi merged 2 commits into
mainfrom
ical

Conversation

@rviscomi

Copy link
Copy Markdown
Owner

Fixes #19

@rviscomi
rviscomi requested a review from Copilot June 30, 2025 16:14

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds iCal calendar download support by introducing new UI sections, styles, and an ICS generator.

  • Inserts download header and footer with iCal buttons into index.html
  • Creates ical-generator.js to build and trigger .ics file download
  • Updates app.js to wire up button click handlers and extends styles.css for styling and responsiveness

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
styles.css Added styles and responsive rules for download header, footer, and buttons
index.html Added header/footer markup with download buttons
ical-generator.js New module to generate and download the iCal calendar file
app.js Imported downloadICal and bound click events to buttons
Comments suppressed due to low confidence (1)

ical-generator.js:3

  • Consider adding unit tests for generateICal() to verify correct ICS formatting, UID generation, and inclusion of expected events.
export function generateICal() {

Comment thread styles.css
Comment thread styles.css Outdated
Comment thread ical-generator.js Outdated
Comment thread index.html Outdated
Comment thread index.html Outdated
<div class="download-container">
<h1>Web Features Timeline</h1>
<p>Timeline of web features and browser support</p>
<button id="download-ical-top" class="download-btn">

Copilot AI Jun 30, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Include an aria-label="Download iCal Calendar" to improve screen reader accessibility for this button.

Suggested change
<button id="download-ical-top" class="download-btn">
<button id="download-ical-top" class="download-btn" aria-label="Download iCal Calendar">

Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@rviscomi
rviscomi merged commit fa56450 into main Jun 30, 2025
2 checks passed
@rviscomi
rviscomi deleted the ical branch June 30, 2025 16:19

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Redundant Media Queries Affect Table Styling

Three separate @media (max-width: 768px) blocks define conflicting and redundant CSS for the .browser-support-table element. The font-size is initially set to 0.875rem but is then overridden by a later declaration of 0.9rem. Additionally, width: 100% is duplicated across these blocks. This results in ineffective styling rules and unnecessary CSS.

styles.css#L845-L957

timebase/styles.css

Lines 845 to 957 in 45b3d4f

/* Responsive styles for the table */
@media (max-width: 768px) {
.browser-support-table {
width: 100%;
max-width: none; /* Allow full width on mobile */
}
}
@media (max-width: 768px) {
.browser-support-table {
font-size: 0.875rem;
}
}
/* Download header and footer styles */
.download-header {
background: linear-gradient(135deg, #667eea 0%, #764ba2 100%);
color: white;
padding: 2rem 0;
text-align: center;
box-shadow: 0 2px 10px rgba(0, 0, 0, 0.1);
}
.download-footer {
background: #f8f9fa;
border-top: 1px solid #e9ecef;
padding: 2rem 0;
text-align: center;
margin-top: 3rem;
}
.download-container {
max-width: 1000px;
margin: 0 auto;
padding: 0 20px;
}
.download-header h1 {
font-size: 2.5rem;
font-weight: 700;
margin-bottom: 0.5rem;
text-shadow: 0 2px 4px rgba(0, 0, 0, 0.1);
}
.download-header p {
font-size: 1.1rem;
opacity: 0.9;
margin-bottom: 1.5rem;
}
.download-footer p {
font-size: 0.9rem;
color: #6c757d;
margin-top: 0.5rem;
}
.download-btn {
background: linear-gradient(135deg, #28a745 0%, #20c997 100%);
color: white;
border: none;
padding: 0.75rem 1.5rem;
border-radius: 8px;
font-size: 1rem;
font-weight: 600;
cursor: pointer;
transition: all 0.3s ease;
box-shadow: 0 4px 15px rgba(40, 167, 69, 0.3);
display: inline-flex;
align-items: center;
gap: 0.5rem;
}
.download-btn:hover {
background: linear-gradient(135deg, #218838 0%, #1ea085 100%);
transform: translateY(-2px);
box-shadow: 0 6px 20px rgba(40, 167, 69, 0.4);
}
.download-btn:active {
transform: translateY(0);
box-shadow: 0 2px 10px rgba(40, 167, 69, 0.3);
}
.download-btn:focus {
outline: none;
box-shadow: 0 0 0 3px rgba(40, 167, 69, 0.3), 0 4px 15px rgba(40, 167, 69, 0.3);
}
/* Adjust timeline container margin for header */
.timeline-container {
max-width: 1000px;
margin: 0 auto;
padding: 2rem 20px;
}
/* Mobile responsive styles for download sections */
@media (max-width: 768px) {
.browser-support-table {
width: 100%;
font-size: 0.9rem;
}
.download-header h1 {
font-size: 2rem;
}
.download-header p {
font-size: 1rem;
}
.download-btn {
padding: 0.625rem 1.25rem;
font-size: 0.9rem;

Fix in Cursor


BugBot free trial expires on July 22, 2025
You have used $0.00 of your $5.00 spend limit so far. Manage your spend limit in the Cursor dashboard.

Was this report helpful? Give feedback by reacting with 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Export in ical format

2 participants