Include PiPy Package and non-iso pixel spacing #14
Conversation
Update numpy and handle pixels spacing as list or tuple
include test for detection
include how to install in README
Fix for patches with different x nd y PixelSpacing
There was a problem hiding this comment.
This python version doesn't match that in the .readthedocs.yaml file (3.9)
| ) -> Tuple[List[List[torch.Tensor]], List[List[Dict]]]: | ||
| """ | ||
| Exhaustively split 3D scan volume into resized, normalized patches for detection. | ||
| Ensures consistency with split_into_patches_exhaustive when px=py. |
There was a problem hiding this comment.
px, py = x and y pixel spacing? If the split_into_patches_exhaustive is redundant now we should remove it.
There was a problem hiding this comment.
is redundant but I did not want to completely remove because I was still in testing phase
There was a problem hiding this comment.
Ah ok - guess it can go now then - it's in the history so no worries if we need to bring it back.
There was a problem hiding this comment.
Not sure what this submodule is, can we remove from MR?
There was a problem hiding this comment.
Oh this is a mistake, I will!
There was a problem hiding this comment.
I think this tutorial notebook is broken in your branch, can you fix it or alternatively checkout the notebook from the main branch?
There was a problem hiding this comment.
You can select when merging but I will come back to the main branch
2 participants
include test for detection by @mariamonzon in mariamonzon#2
What's Changed
Update numpy ans isotropic voluumes by @mariamonzon in mariamonzon#1
make spinNet compatible with different pixel spacing [px,py]
validate detection and polygon coords are within image size
include test for detection by @mariamonzon in mariamonzon#2
include how to install in README by @mariamonzon in mariamonzon#3
New Contributors
@mariamonzon
Full Changelog: https://github.com/mariamonzon/SpineNet/commits/v.2.0.3