Some fixes for SLURM and SGE engine - #306
Merged
Merged
Conversation
albertz
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on the engine for a different project, my LLM pointed out some problems:
job_idis alist[str]instead of a singlestras it is for all other enginesend_idis inclusive, for range it is exclusive.rqmt_hist[0] == rqmtis never true. Instead, I now compare ifrqmt_hist[0]is a subset of current rqmt and if not only update the changed keys.This changes the content of
submit_log.<task>.<id>but since we don't use this file for anything anyway, I decided against including compatibillity code.before
now
(note the changed
engine_info)