avoid possible race conditions#54
Merged
michaelglass merged 1 commit intoomnibus-test-change-branchfrom Dec 9, 2022
Merged
Conversation
michaelglass
force-pushed
the
avoid-race-condition
branch
2 times, most recently
from
932d67d to
83a0c14
Compare
michaelglass
changed the title
michaelglass
force-pushed
the
avoid-race-condition
branch
from
c55d7dc to
f0254b9
Compare
michaelglass
changed the title
michaelglass
force-pushed
the
avoid-race-condition
branch
from
f0254b9 to
97f738f
Compare
michaelglass
changed the title
michaelglass
added a commit
that referenced
this pull request
Dec 9, 2022
michaelglass
added a commit
that referenced
this pull request
Dec 9, 2022
* fail on missing snapshots (#57) * include fork of rspec-snapshot that fails the build when the snapshot is written * confirm missing snapshots fail the build * Revert "confirm missing snapshots fail the build" This reverts commit b4e3dd2. * test exit more carefully (#56) * graceful exit within abq was masking rspec tests on older versions of rspec * add an additional exit safeguard * check num tests vs expected tests * sanitize backtrace tweaks * regenerate snapshots * break test to ensure bin/check_num_tests.rb works * Revert "break test to ensure bin/check_num_tests.rb works" This reverts commit 1da32a2. * set subprocess ENV outside of the global context (#54) * use captain cli (#55) * use captain cli * unset RWX_ACCESS_TOKEN to be compatible with captain-cli
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves possible race conditions while generating gem lockfile updates and snapshots