Added start/end of string, "hex", modifiers #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why can't a regex have more than one start/end of line? They can now. Also, using "alternatively" broke when combined with end_of_line due to an implementation bug. Not anymore!
Often, people use ^ and $, when actually they would be better with \A and \z
Forgot to use DOUBLE quotes for "\n"
This is also a slight BUG FIX, since regexes were being produced as case insensitive by default!
0.2.0 as this is a significant new feature, and could genuinely cause slight backwards compatibility issues because of the bug fix.
This reverts commit e6bfa87.
(oops.)
tom-lord
changed the title
Modifiers are now implemented, as of version 0.2.0
This was inspired by the 'original' JavaScript version's feature: searchOneLine(). The :whole_line modifier can potentially be violated if, for example, the user includes "\n" in the search pattern - but there's not much can be done about that!
0.2.0 --> 0.2.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.1.5 --> 0.1.6:
This make version 0.1.6 slightly incompatible with the previous, but the change (which only affects weird uses of
start/end_of_line, and some uses foralternatively) is unlikely to even be noticed.0.1.6 --> 0.2.0
Added modifiers. I.e. ignorecase and multiline. These can be passed in as parameters with the VerEx constructor, e.g.
VerEx.new(:ignorecase) do ......This is also a slight bug fix, since
VerEx.newwas creating case insensitive regular expressions by default. From the ruby docs:If options is a Fixnum, it should be one or more of the constants Regexp::EXTENDED,
Regexp::IGNORECASE, and Regexp::MULTILINE, or-ed together. Otherwise, if options is not nil or false,
the regexp will be case insensitive.
Previously, modifiers was being defaulted to an empty string, not nil or false.
0.2.0 --> 0.2.1
P.s. I didn't want to re-generate the gemspec myself as I'm submitting this on a Windows machine which has all different versions of things installed.