[CI verify] chore(paywall): regenerate bundle + add recurrence guard#2
Closed
[CI verify] chore(paywall): regenerate bundle + add recurrence guard#2
Conversation
22381fa to
b793c3c
Compare
Owner
Author
|
Closing to force recompute after fork-main sync. Will reopen. |
160e1aa to
5068350
Compare
The committed @x402/paywall bundle on main was last generated against an older viem than the lockfile currently pins. pnpm install --frozen-lockfile resolves viem 2.47.12 (via x402-foundation#2013), but the bundled src/evm/gen/template.ts (and its Python + Go siblings) were built against an earlier resolution that pre-dated chain definitions for Mezo, MegaETH, Stable, Radius (each with a testnet variant), and 33 others. EvmPaywall.tsx throws "Unsupported chain ID" at init for any eip155:<id> whose chain isn't in the bundled viem/chains. This PR: 1. Regenerates all nine auto-generated template files (TypeScript, Python, and Go for EVM/SVM/AVM) against the current lockfile. No source changes on any runtime path. 2. Teaches build:paywall to emit output matching the repo's formatters (prettier / ruff), so generated files stay clean under pnpm run format + uvx ruff format. 3. Adds a PR-time drift check (.github/workflows/check_paywall_template.yml) so a future lockfile or @x402/evm change that invalidates the bundle fails loudly instead of shipping silently. Scope is limited to @x402/paywall because it is the only package in this repo that bakes viem chain definitions into a built artifact. Verified on a fork-internal test PR running on ubuntu-latest (Node 24, pnpm 10.7.0): check_format, check_lint, check_go, check_python, check_package_lock, and the new check_paywall_template drift check all pass. Additional local evidence: - Chain-presence in regenerated bundle: Mezo 31612/31611, MegaETH 4326/6343, Stable 988/2201, Radius 723487/72344, Base/Arbitrum/ Polygon all present (mainnet/testnet ordering). - Cross-platform determinism: a clean-slate rebuild on macOS produces byte-identical output to ubuntu-latest CI. - Tarball install into a throwaway consumer: all expected chain IDs present in the published dist/esm/evm/index.js. - Browser smoke test (Chrome, served from a local HTTP server): EvmPaywall mounts without Unsupported-chain throw for eip155:31611 (Mezo Testnet) and eip155:723487 (Radius); DOM renders the expected token/chain labels. Fixes x402-foundation#1971.
5068350 to
2c1fbb6
Compare
ryanRfox
added a commit
that referenced
this pull request
Apr 29, 2026
…t URL feature Add changelog fragments to satisfy the Go and Python contribution guides ahead of upstream filing of the chain-aware faucet URL feature (commits dc6bb53 + fbcef1c on this branch). The TS changeset already lives at typescript/.changeset/paywall-faucet-url-registry.md; this commit brings Go and Python to the same changelog-fragment posture. - go/.changes/unreleased/added-20260429-103814.yaml — Changie fragment describing the new exported PaywallConfig.FaucetURL, PaywallConfig.FaucetURLs, and AssetInfo.FaucetURL on EVM and SVM. - python/x402/changelog.d/PR_TBD.feature.md — Towncrier fragment describing PaywallConfig.faucet_url, PaywallConfig.faucet_urls, PaywallBuilder.with_config(faucet_url=, faucet_urls=), and AssetInfo.faucet_url on EVM and SVM. Filename uses the placeholder PR_TBD prefix; the real PR number gets substituted after gh pr create. Address halt flags #1 and #2 from the independent senior review at fbcef1c. No code change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fork-internal PR for CI verification only. Do not merge.
Opened against
ryanRfox/x402:main(not upstream) to verify the newcheck_paywall_template.ymlworkflow executes successfully in GitHubActions before the real PR is opened against x402-foundation/x402.
Once the workflow run here shows green, this PR can be closed and the
upstream PR opened against
x402-foundation/x402:mainwith the fullPR description body.
Expected workflow runs on this PR:
check_python, check_package_lock)