Fix misleading failed-login log entries when login-email is enabled#30
Open
gebeer wants to merge 1 commit into
Open
Fix misleading failed-login log entries when login-email is enabled#30gebeer wants to merge 1 commit into
gebeer wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
login-emailis enabled,LoginRegistercurrently attempts to log in withemailToName($email)first, and only then falls back to looking up the user by email and retrying with the real username.For installs where the actual username does not match the email-derived page name, this produces a misleading failed login entry in
session.txteven though the login succeeds on the second attempt.Example:
Error: Failed login for 'admin-hugoerke.de' - Unknown userSuccessful login for 'hg-admin'Fix
When
login-emailis enabled and the submitted login value looks like an email address, resolve it to the actual user name before callingSession::login().Behavior after this change:
login-emailenabled + one matching email: log in once with the real usernamelogin-emailenabled + multiple matching emails: keep the existing duplicate-email errorlogin-emaildisabled: keep the existing username login behaviorThis avoids false failed-login log entries for successful email logins without changing behavior for installations that do not use
login-email.