Skip to content

Fix bug by syncing ExoPlayer shuffleOrder on setShuffleOrder (Closes #1551)#1555

Open
LennartEnns wants to merge 1 commit into
ryanheise:minorfrom
LennartEnns:fix/exo-player-shuffle-order
Open

Fix bug by syncing ExoPlayer shuffleOrder on setShuffleOrder (Closes #1551)#1555
LennartEnns wants to merge 1 commit into
ryanheise:minorfrom
LennartEnns:fix/exo-player-shuffle-order

Conversation

@LennartEnns

Copy link
Copy Markdown

This pull request solves Issue #1551.
Warning: Not thoroughly tested yet, but since effectively only 1 line has been changed, this should not take long.

@Chaphasilor

Chaphasilor commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

We're able to reproduce this bug (#1551) in finamp-app/finamp#1442.
Thanks for whipping up the PR @LennartEnns, I've tested it and the issue is indeed fixed there.

There is another (potentially) related issue when toggling shuffle mode, where the playbackEventStream isn't emitting a new event even though the current index is changing due to shuffle being toggled.
Edit: sorry for hitting send to early.

@lachy874125

Copy link
Copy Markdown

This fixes the issue for me. Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants