feat: support 360 DPI devices like PT-P910BT #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is about as minimal an implementation as I can manage at the moment, though it still passes around the resolution more than I might like. Tested on both a PT-P910BT and a PT-P710BT. Closes ryankurte#60. (Also adds debug logging of data read from the USB device alongside logging of data written.)
|
good effort! i need to fix the CI but otherwise happy to merge the new functionality / play with things later if we come up with better abstractions.
of course 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is about as minimal an implementation as I can manage at the moment, though it still passes around the resolution more than I might like. Tested on both a PT-P910BT and a PT-P710BT.
Closes #60.
(Also adds debug logging of data read from the USB device alongside logging of data written.)
This works, but it may not necessarily be in keeping with what you were thinking. The changes end up affecting most of the classes, because most of them need to know the DPI for various reasons. (Even down to the level of the
set_print_infocommand, which apparently needs to set the page type to 2 for 360 DPI printers in order to trigger the "last page" behavior including printing smaller labels or cutting any labels. But of course setting it to 2 in 180 DPI printers causes them to hang.)If you'd like any changes, I'm happy to either attempt them myself, or you're welcome to make the relevant changes to my branch if you'd like.