add additional list type support - #33
Merged
Merged
Conversation
|
Coverage after merging add-additional-list-type-support into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for scraping actor, director, and writer filmography pages from Letterboxd. The implementation reuses the existing ListScraper class since filmography pages share the same HTML structure as regular lists.
- Consolidates filmography case statements with watchlist and regular list cases
- Updates unit and integration tests to verify filmography scraping functionality
- Updates README documentation to move filmography URLs from "Planned Support" to "Currently Supported"
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/scraper/index.ts | Adds filmography case statements to the existing list scraping logic, removes TODO error throws |
| src/scraper/index.test.ts | Updates tests to verify filmography scraping works correctly instead of expecting errors |
| src/scraper/index.itest.ts | Adds integration tests for all three filmography types using real Letterboxd URLs |
| README.md | Updates documentation to reflect that filmography URLs are now supported with usage examples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.