Open
Conversation
Collaborator
DoctorBud
commented
Jul 8, 2020
DoctorBud
commented
- Adds 'make run-pretty' option to format log output in a more human-readable way.
- Fixes typos in a couple places
- Adds static/examples/mirror.html, which synthesizes a video source and acts as a peer.
- Adds links to other examples to bottom of static/index.html
- Adds js/mirrormedia.js which uses a Canvas to create a peer video stream.
- In peering.js, add a 1-second delay before manually firing .play() on a newly created video element. This resolves random issues where even an autoplay video element doesn't start playing automatically.
…readable way. - Fixes typos in a couple places - Adds static/examples/mirror.html, which synthesizes a video source and acts as a peer. - Adds links to other examples to bottom of static/index.html - Adds js/mirrormedia.js which uses a Canvas to create a peer video stream. - In peering.js, add a 1-second delay before manually firing .play() on a newly created video element. This resolves random issues where even an autoplay video element doesn't start playing automatically.
ryanrolds
reviewed
Jul 8, 2020
|
|
||
| run-pretty: build | ||
| # open http://localhost:3001 | ||
| ENV=local ./backend 2>&1 | jq --raw-output '[("# " + .level + (" " * 10))[0:10], (.func + (" " * 20))[0:20], .msg] | @tsv' |
Owner
There was a problem hiding this comment.
Why not have the local env var change the logging formatter used? https://github.com/ryanrolds/club/blob/master/golang/cmd/backend/logging.go#L21
Comment on lines
+82
to
+85
| setTimeout(() => { | ||
| video.play() | ||
| }, 1000) | ||
|
|
Owner
There was a problem hiding this comment.
Any more details on the race condition that requires this? Are we not emitting an event somewhere? Maybe the issue is the lack of handling of the negotiationneeded, which the frontend should be handling correctly now.
ryanrolds
requested changes
Jul 18, 2020
Owner
ryanrolds
left a comment
ryanrolds
left a comment
There was a problem hiding this comment.
Requesting the above changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.