Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -86,4 +86,7 @@ IMAGE_TAG=latest
# Port mapping (only needed for custom ports or --no-webserver)
HOST_BACKEND_PORT="3001:3001"
HOST_CLIENT_PORT="3002:3002"
```

# ClickHouse insert retries for pageview queue (default: 3 retries after the initial attempt)
PAGEVIEW_QUEUE_MAX_RETRIES=3
```
29 changes: 25 additions & 4 deletions server/src/services/tracker/pageviewQueue.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ type TotalPayload = TotalTrackingPayload & {
sessionId: string;
};

const parsePositiveNumber = (value: string | undefined, fallback: number) => {
const parsed = Number(value);
return Number.isFinite(parsed) && parsed > 0 ? parsed : fallback;
};

const getParsedProperties = (properties: string | undefined) => {
try {
return properties ? JSON.parse(properties) : undefined;
Expand All @@ -24,6 +29,7 @@ class PageviewQueue {
private interval = 10000;
private processing = false;
private logger = createServiceLogger("pageview-queue");
private maxRetries = parsePositiveNumber(process.env.PAGEVIEW_QUEUE_MAX_RETRIES, 3);

constructor() {
// Start processing interval
Expand Down Expand Up @@ -116,17 +122,32 @@ class PageviewQueue {
});

this.logger.info({ count: processedPageviews.length }, "Bulk insert to ClickHouse");
// Bulk insert into database
try {
await this.insertBatchWithRetry(processedPageviews);
} catch (error) {
this.logger.error(error, `Error processing pageview queue after ${this.maxRetries + 1} attempts, dropping ${batch.length} items`);
} finally {
this.processing = false;
}
}

private async insertBatchWithRetry(processedPageviews: Record<string, unknown>[], retryCount = 0): Promise<void> {
try {
await clickhouse.insert({
table: "events",
values: processedPageviews,
format: "JSONEachRow",
});
} catch (error) {
this.logger.error(error, "Error processing pageview queue");
} finally {
this.processing = false;
if (retryCount >= this.maxRetries) {
throw error;
}

const retryAttempt = retryCount + 1;
const delay = this.interval * Math.pow(2, retryCount);
this.logger.warn({ retryAttempt, delay }, "Bulk insert to ClickHouse failed, retrying");
await new Promise(resolve => setTimeout(resolve, delay));
await this.insertBatchWithRetry(processedPageviews, retryCount + 1);
}
}
}
Expand Down