IRC: let authenticated users join channels on registered servers#1044
Open
ryokun6 wants to merge 1 commit intocursor/add-irc-chat-support-6c78from
Open
IRC: let authenticated users join channels on registered servers#1044ryokun6 wants to merge 1 commit intocursor/add-irc-chat-support-6c78from
ryokun6 wants to merge 1 commit intocursor/add-irc-chat-support-6c78from
Conversation
- GET /api/irc/servers/:id/channels: require auth only (not admin) - POST /api/rooms type=irc: non-admins must send ircServerId and channel must appear in server LIST; admins may still use custom host/port - CreateRoomDialog: IRC tab for all users; add/delete server admin-only; non-admins pick channels from list only - Wire ircServerId through client createRoom payload Co-authored-by: Ryo Lu <me@ryo.lu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/irc/servers/:id/channels): any authenticated user can browse channels on servers already in the registry; adding/removing servers stays admin-only.POST /api/roomswithtype: "irc"): non-admins must sendircServerId(registry id); the server runs LIST and only allows the channel if it appears in that snapshot (prevents arbitrary host/port from non-admins). Admins keep the previous flexibility (optionalircServerIdor manual host/port/label).Testing
bun run buildbun test tests/test-irc-bridge.test.ts