feat(karaoke): open Cover Flow from title card album art#1053
Draft
feat(karaoke): open Cover Flow from title card album art#1053
Conversation
Add handleOpenCoverFlow so clicking the title card cover always opens Cover Flow (when the library has tracks) without toggling it closed. Co-authored-by: Ryo Lu <me@ryo.lu>
|
The preview deployment for ryos-dev is ready. 🟢 Open Preview | Open Build Logs | Open Application Logs Last updated at: 2026-04-26 04:27:43 CET |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aria-labeluses the existing iPod Cover Flow menu string). Click/tap opens Cover Flow and does not steal clicks from the rest of the screen (only the sleeve area usespointer-events-auto).handleOpenCoverFlowso opening from the title card always shows Cover Flow when the library has tracks, without toggling it closed if it was already open (unlikehandleToggleCoverFlow).onTitleCardCoverClickfor window and fullscreen lyrics overlays; marks user interaction andregisterActivity()for autoplay / UI timers.Testing
PATH="/root/.bun/bin:$PATH" bun run build— TypeScript + Vite production build succeeded.No browser walkthrough: AGENTS.md says to skip GUI testing unless requested; change is a small click handler plus build verification.