Develop #178

rzeldent · 2025-11-11T21:41:17Z

No description provided.

fixed Sewrial issue esp32s2

…nto develop

Retry 3 times camera init

Co-authored-by: Nick Eales <[email protected]>

* add support for M5PoECAM-W (U121-B) * update documentation for newly added M5PoECAM-W * update board values for m5poecam-w

…king 133-esp32-cam-led-flash-not-working

Add the m5stack-timer-cam definitions following information from the board documentation [1] and the board entry on platform.io [2]. Tweak the upload speed to use a known working value. Mention the X version in the readme as well since it uses the same board and is just a chassis change. [1] https://docs.m5stack.com/en/unit/timercam [2] https://github.com/platformio/platform-espressif32/blob/ec69109ed6e2bb19464266357436c028a60560c3/boards/m5stack-timer-cam.json Signed-off-by: Randolph Sapp <[email protected]>

platformio.ini: add m5stack-timer-cam

Added S3 wroom n16r8 board

Copilot

Pull Request Overview

This PR adds support for new ESP32-CAM board variants and introduces flash LED control functionality. The changes include support for the M5Stack M5PoECAM-W, M5Stack Timer CAM, and ESP32 S3 WROOM n16r8 boards, along with HTTP endpoint for controlling flash LEDs on compatible boards. Additionally, the platform version is pinned to [email protected] for consistency, and indentation in camera configuration is standardized.

Key changes:

Added flash LED control via HTTP endpoint /flash for boards with flash LED support
Moved Serial initialization earlier in setup to ensure debug output is available from the start
Pinned platform version to [email protected] for reproducible builds

Reviewed Changes

Copilot reviewed 8 out of 10 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
src/main.cpp	Added flash LED control function and HTTP handler; moved Serial.begin() earlier; standardized camera_config indentation
platformio.ini	Pinned platform version to [email protected]; added new board environments for m5stack-timer-cam and esp32cam_s3_wroom_n16r8
boards/m5stack-timer-cam.json	New board definition for M5Stack Timer CAM with ESP32 and PSRAM support
boards/esp32cam_s3_wroom_n16r8.json	New board definition for ESP32-S3 WROOM with 16MB flash and 8MB PSRAM
boards/esp32cam_m5stack_m5poecam_w.json	New board definition for M5Stack M5PoECAM-W with ESP32 and PoE support
boards/esp32cam_ai_thinker.json	Added FLASH_LED_GPIO=4 definition for AI Thinker board
boards/esp32cam_m5stack_unitcams3.json	Updated camera pin assignments to correct GPIO mappings
README.md	Added new boards to supported list; updated PSRAM table; added August 2024 change history entry
dotnet_riscv	Removed subproject commit reference
assets/boards/*.webp	Added product images for M5Stack M5PoECAM-W

Comments suppressed due to low confidence (1)

README.md:50

The newly added "ESP32 S3 WROOM n16r8" board (defined in boards/esp32cam_s3_wroom_n16r8.json and platformio.ini) is missing from the list of supported ESP32-CAM modules. It should be added to maintain consistency with the other supported boards.

This software supports the following ESP32-CAM (and alike) modules:

- AI THINKER
- EspressIf ESP-EYE
- EspressIf ESP32S2-CAM
- EspressIf ESP32S3-CAM-LCD
- EspressIf ESP32S3-EYE
- Freenove WROVER KIT
- M5STACK ESP32CAM
- M5STACK_PSRAM
- M5STACK_UNITCAM
- M5STACK_UNITCAMS3
- M5STACK_V2_PSRAM
- M5STACK_PSRAM
- M5STACK_WIDE
- M5STACK M5PoECAM-W
- M5STACK Timer CAM (Original and X)
- M5STACK
- Seeed Studio XIAO ESP32S3 SENSE
- TTGO T-CAMERA
- TTGO T-JOURNAL

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-11T21:45:10Z

src/main.cpp

+      .grab_mode = CAMERA_GRAB_LATEST,            // When buffers should be filled
 #if CONFIG_CAMERA_CONVERTER_ENABLED
-    conv_mode = CONV_DISABLE, // RGB<->YUV Conversion mode
+      conv_mode = CONV_DISABLE, // RGB<->YUV Conversion mode


The conv_mode field is missing a dot prefix (.) for designated initializer syntax. This should be .conv_mode = CONV_DISABLE to match the C99 designated initializer pattern used throughout the rest of the structure.

Suggested change

conv_mode = CONV_DISABLE, // RGB<->YUV Conversion mode

.conv_mode = CONV_DISABLE, // RGB<->YUV Conversion mode

Copilot · 2025-11-11T21:45:11Z

boards/esp32cam_m5stack_m5poecam_w.json

+  ],
+  "name": "ESP32-CAM M5STACK M5PoECAM-W",
+  "upload": {
+    "flash_size": "16MB",


The flash size is inconsistent with the partition configuration. The board defines "partitions": "default_8MB.csv" (line 5) but specifies "flash_size": "16MB" (line 60). These should match - either both should be 8MB or both 16MB based on the actual hardware specifications.

Suggested change

"flash_size": "16MB",

"flash_size": "8MB",

Copilot · 2025-11-11T21:45:11Z

README.md

+| M5STACK_ESP32CAM   | No             |
+| M5STACK_UNITCAM    | No             |
+| M5STACK_UNITCAMS3  | 8Mb            |
+| M5STACK_M5PoECAM-W | 8MB            |


The table formatting uses inconsistent units for PSRAM sizes. Most entries use "8Mb" (megabits) but this entry uses "8MB" (megabytes). For consistency with the rest of the table, this should be "8Mb".

Suggested change

| M5STACK_M5PoECAM-W | 8MB |

| M5STACK_M5PoECAM-W | 8Mb |

Copilot · 2025-11-11T21:45:12Z

boards/esp32cam_s3_wroom_n16r8.json

+    "url": "https://docs.espressif.com/projects/esp-idf/en/latest/esp32s3/hw-reference/esp32s3/user-guide-devkitc-1.html",
+    "vendor": "Espressif"


The "url" and "vendor" fields have inconsistent indentation. They should be aligned at the same level as "upload" (2 spaces), but instead they have 4 spaces. This breaks the JSON structure consistency.

Suggested change

"url": "https://docs.espressif.com/projects/esp-idf/en/latest/esp32s3/hw-reference/esp32s3/user-guide-devkitc-1.html",

"vendor": "Espressif"

"url": "https://docs.espressif.com/projects/esp-idf/en/latest/esp32s3/hw-reference/esp32s3/user-guide-devkitc-1.html",

"vendor": "Espressif"

Copilot · 2025-11-11T21:45:12Z

README.md

 ## Change history

+- August 2024
+  - Added support for M5Stack M5PoECAM-W


The change history entry only mentions "M5Stack M5PoECAM-W" but the PR also adds support for "M5Stack Timer CAM" and "ESP32 S3 WROOM n16r8" boards. These should be included in the change history for completeness.

Suggested change

- Added support for M5Stack M5PoECAM-W

- Added support for M5Stack M5PoECAM-W, M5Stack Timer CAM, and ESP32 S3 WROOM n16r8

Copilot · 2025-11-11T21:45:12Z

src/main.cpp

+  log_v("handle_flash");
+  // If no value present, use off, otherwise convert v to integer. Depends on analog resolution for max value
+  auto v = web_server.hasArg("v") ? web_server.arg("v").toInt() : 0;
+  // If conversion fails, v = 0


The handle_flash function lacks input validation for the v parameter. The toInt() method can return negative values or values exceeding the valid range (0-255 for 8-bit resolution). Consider adding validation to clamp the value: auto v = constrain(web_server.hasArg("v") ? web_server.arg("v").toInt() : 0, 0, 255);

Suggested change

// If conversion fails, v = 0

v = constrain(v, 0, 255); // Clamp value to valid range for 8-bit PWM

rzeldent and others added 30 commits August 17, 2023 01:57

Added seeed_xiao_esp32s3

b3cb7d1

Fixed typo

4360630

Updating build system

6917e44

Fixed typos

fdc0ddd

Renamed envirnment name to seeed_xiao_esp32s3

5b7d6f9

Update README.md

ed293eb

Updated platformio definitions

0809f6b

Added cache

9ecdd1c

Merge branch 'feature/seeed_xiao_esp32s3' into develop

6850c2c

Updated README.md

351c6a2

- Default value for initResult if initialzation fails

7f37bff

constexpr camera_config_t m5stack_camera_settings

51c5bf0

Added M5Stack UnitCamS3

d0ef68b

Work in progress

5bdfc45

WIP

a90c4fe

Work in progress

e8cdf6d

Removed OTA

545a824

Added unitcams3

138c620

UnitcamS3

8e5f4ee

Corrected HTML for ipv4

f9336ad

fixed Sewrial issue esp32s2

USER_LED_ON_LEVEL=LOW

50f4b6f

Added documentation pins for Mems/grove/led

4df6c94

Typo

7b4f4c0

Removed non required depencency

60b602b

Removed non required depencency

4239de2

Merge branch 'develop' of https://github.com/rzeldent/esp32cam-rtsp i…

fd21f32

…nto develop

Readded

9ba1116

Merge branch 'main' into develop

1c22364

Added sccb_i2c_port

a760fda

Retry 3 times camera init

Added Freenove wroom-1 n8r8 board (#112)

613965e

Co-authored-by: Nick Eales <[email protected]>

volnix and others added 15 commits February 23, 2024 19:42

Fixing missing comma in xiao board json (#114)

e702191

Updated Markdown

80a23aa

Merge branch 'main' into develop

c61e6cd

Merge branch 'main' into develop

c1d92bc

Merge branch 'main' into develop

383d580

Update with settings from Sheed

fe7195c

Add support for M5PoECAM-W (#140)

069e6ff

* add support for M5PoECAM-W (U121-B) * update documentation for newly added M5PoECAM-W * update board values for m5poecam-w

Merge branch 'main' into develop

8be1484

Added functions for flasg from API

e93511d

Merge pull request #158 from rzeldent:133-esp32-cam-led-flash-not-wor…

32cbc24

…king 133-esp32-cam-led-flash-not-working

Merge pull request #170 from StaticRocket/develop

346deda

platformio.ini: add m5stack-timer-cam

Added s3 wroom n16r8

e3a7a0c

Merge pull request #177 from csabyka/develop

c1beb4d

Added S3 wroom n16r8 board

Comment out default environment and upload port in platformio.ini

efb7258

Copilot AI review requested due to automatic review settings November 11, 2025 21:41

Copilot started reviewing on behalf of rzeldent November 11, 2025 21:41 View session

Merge branch 'main' into develop

46eaabc

rzeldent merged commit b87ddba into main Nov 11, 2025
2 checks passed

Copilot finished reviewing on behalf of rzeldent November 11, 2025 21:44

Copilot AI reviewed Nov 11, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Develop #178

Develop #178

Uh oh!

rzeldent commented Nov 11, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 11, 2025

Uh oh!

Copilot AI Nov 11, 2025

Uh oh!

Copilot AI Nov 11, 2025

Uh oh!

Copilot AI Nov 11, 2025

Uh oh!

Copilot AI Nov 11, 2025

Uh oh!

Copilot AI Nov 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

	conv_mode = CONV_DISABLE, // RGB<->YUV Conversion mode
	.conv_mode = CONV_DISABLE, // RGB<->YUV Conversion mode

		"url": "https://docs.espressif.com/projects/esp-idf/en/latest/esp32s3/hw-reference/esp32s3/user-guide-devkitc-1.html",
		"vendor": "Espressif"

	- Added support for M5Stack M5PoECAM-W
	- Added support for M5Stack M5PoECAM-W, M5Stack Timer CAM, and ESP32 S3 WROOM n16r8

	// If conversion fails, v = 0
	v = constrain(v, 0, 255); // Clamp value to valid range for 8-bit PWM

Develop #178

Develop #178

Uh oh!

Conversation

rzeldent commented Nov 11, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants