Add missing headers when ocl.h doesn't include them #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some distro's OpenCL header (e.g AlmaLinux 9, also applies to any EL Linux like RHEL and Rocky) are conservative and does not transitively include
stdlib.h
so when building on such a platform, we get:While unverified, I suspect there is a high percentage of users with an NVIDIA OpenCL header which doesn't have this issue because the header is brought in at some point on their side.
This PR simply adds
#include <stdlib.h>
in the two places where's actually used.With this change, the package builds on vanilla AlmaLinux 9.4 with just
ocl-icd-devel
(OpenCL headers):