fix for ignored body data on post requests with urls containing param… #432
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it implement/fix? Explain your changes.
When a POST request includes both URL parameters and body data, the body data is ignored.
The current implementation assumes that if parameters are present in the URL, there is no data in the body.
This issue can be replicated using the search request on http://testphp.vulnweb.com, where the
searchForparameter is vulnerable to XSS.For example, if the following request is made:
the body data is disregarded, and no reflection is detected. However, if no URL parameter is provided:
the reflection is detected.
This commit addresses the issue by rewriting the
getParamsfunction incore/utils.py.Where has this been tested?
Python Version: 3.9.6
Operating System: MacOS 15.4
Does this close any currently open issues?
No.
Does this add any new dependency?
No.
Does this add any new command line switch/option?
No.
Any other comments you would like to make?
n/a
Some Questions