refactor!: expose keys via env variable #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluebrown
force-pushed
the
refactor/keys
branch
5 times, most recently
from
abb0c05 to
061edda
Compare
the access and secret key are now registered as secret and then exposed to s3cmd via the env variables AWS_ACCESS_KEY and AWS_SECRET_KEY. This prevents the need to write them to disk. However, it can happen that this interferes with other values the user needs for these variables. Usually it should be aligned, even if these keys are used for other purposes. Because they operate on the same account. Signed-off-by: Nico Braun <[email protected]>
bluebrown
force-pushed
the
refactor/keys
branch
from
061edda to
0b4175f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the access and secret key are now registered as secret and then exposed
to s3cmd via the env variables AWS_ACCESS_KEY and AWS_SECRET_KEY. This
prevents the need to write them to disk. However, it can happen that
this interferes with other values the user needs for these variables.
Usually it should be aligned, even if these keys are used for other
purposes. Because they operate on the same account.