Fix installation fails when using Let's Encrypt cluster issuer#119
Fix installation fails when using Let's Encrypt cluster issuer#119PhanLe1010 wants to merge 3 commits intos3gw-tech:mainfrom
Conversation
The consumers need to reference the correct name of the tlsIssuers. Cosummers are traefik ingress and the cluster-ip-cert Signed-off-by: Phan Le <phan.le@suse.com>
Signed-off-by: Phan Le <phan.le@suse.com>
Signed-off-by: Phan Le <phan.le@suse.com>
|
Hi @PhanLe1010 . Thank you for your contribution. It will be reviewed shortly. In the meantime, would you mind signing your commits in this patch set? If you are not familiar with how commits can be signed, please refer to the github documentation. |
jecluis
left a comment
jecluis
left a comment
There was a problem hiding this comment.
I'm concerned about dropping support for wildcard certificates. This will break vhost-based bucket access.
Also, please keep in mind that you should remove lines instead of commenting them, unless there's a compelling reason to leave them commented in the code.
| - hosts: | ||
| - '{{ include "s3gw.serviceName" . }}.{{ .Values.publicDomain }}' | ||
| - '*.{{ include "s3gw.serviceName" . }}.{{ .Values.publicDomain }}' | ||
| # - '*.{{ include "s3gw.serviceName" . }}.{{ .Values.publicDomain }}' |
There was a problem hiding this comment.
Maybe @m-ildefons can comment on this, but I think this will not work. We need wildcard certificates for vhost-based bucket access.
There was a problem hiding this comment.
Thanks @jecluis , we are discussing this wildcard cert topic inside our discuss-s3gw Slack channel. I will update the PR once we come to a conclusion
2 participants
Describe your changes
This PR fixes 3 bugs described in each commits:
Issue ticket number and link
Checklist before requesting a review