You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you for your contribution.
The problem that you are trying to fix is a real one, I agree, but there is a practical problem with your PR:
With your change, the ls command will alternatively list "prefixes" (ie "folders") and "files".
In the current case it will create a regression, but also if it was for a new command, the behavior would still be strange.
It is probably why the ls command was not modified to use directly the "streaming list".
Thank you for looking, I would not call that behaviour strange, maybe unexpected. It is still consumable, it is way stranger to run out of memory and coredump :)
Maybe we can look at few other options:
streaming command line option, or automatic one depending on the size of the bucket (and maybe free memory on the system)
write prefixes and file data to tmp files, then print from there, instead of gathering in memory, still can run out of disk space, but probably can be monitored, so it would stop at the right time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to list a very large bucket ~1M objects s3cmd runs out of memory.