lightbox: Drop pretty photo & jQuery #179
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrettyPhoto was abandoned and ther is no clear successor. With https://github.com/lachlan-00/prettyphoto there is a version that works with modern jQuery, but it still has broken elements like a twitter embed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing for jQuery 3, I noticed that the pretty photo lightbox variant was broken. The project is abandoned, see https://github.com/scaron/prettyphoto. https://github.com/lachlan-00/prettyphoto provided some needed updates, but still has outdated elements like a Twitter (not X) embed.
A second commit removes the included jQuery file. It was quite old, and by now all s9y installations ought to be new enough to provide their own. This should reduce maintenance work by not having to think about upgrading the included jQuery file. But it's not a necessary change.