fix(root color): try to better split the concerns about background color #4295
+4
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- apply the same background in both rootcolor and rootscrollgutter - removed fallback to --color-base-100 in rootcolor because it is set in the same included file - if rootcolor is not included then --root-bg is not set so by default background will be transparent, and when we have scroll gutter the scrollbar will be gray - if rootscrollgutter is not included then we will not have grey on scroll gutter This is not a fix for the issue, it's just a better separation of concerns between the 2 files The issue is self-inflicted by setting the bg color in the base layer instead of a higher priority layer. ref saadeghi#4294
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a fix for the issue, it's just a better separation of concerns between the 2 files
The issue is self-inflicted by setting the bg color in the base layer instead of setting
--root-bgor setting the background color in a higher priority layer.ref #4294