feat(tooltip): add alignment utility classes (start, center, end)#4363
feat(tooltip): add alignment utility classes (start, center, end)#4363pdanpdan wants to merge 2 commits intosaadeghi:masterfrom
Conversation
- apply to all positions (top, bottom, left, right) - add a new variable --tt-tail-off to set offset of the tail for start and end alignment example: https://play.tailwindcss.com/Qt8vZTMlSe?file=css close saadeghi#4229
saadeghi
left a comment
There was a problem hiding this comment.
Thanks for the PR @pdanpdan
There's a concern about the new class names.
The existing class names for left and right were bad ideas, because ideally tooltip should adapt the LTR/RTL direction and in result a left tooltip will go right on a RTL layout.
So I think at some point we should rename left and right to start and end, so the name won't be confusing for the opposite direction.
Or to avoid a breaking change we can add start and end as aliases for left and right.
As a result, these new class names should use some name other than start or end. Maybe tooltip-tail-start or something. Let me know if you have any suggestions.
|
Maybe |
|
I think It may not be clear what is But |
|
Are you changing the names or should I go with the rename? |
|
I will rename after merging to |
example: https://play.tailwindcss.com/Qt8vZTMlSe?file=css
close #4229