fix(prefix): replace only the variable name, not all content of var(...)#4373
Open
pdanpdan wants to merge 1 commit intosaadeghi:masterfrom
Open
fix(prefix): replace only the variable name, not all content of var(...)#4373pdanpdan wants to merge 1 commit intosaadeghi:masterfrom
var(...)#4373pdanpdan wants to merge 1 commit intosaadeghi:masterfrom
Conversation
…...)` - existing regex was matching all text after `var(--` until the first `)` - that solution does not work for `var` in `var` (`var(--a, var(--b))`) - new implementation will only replace the variable name (`[a-zA-Z0-9_-]+`) - it also accepts spaces between `var` and `(` and between `(` and `--` - as this regex is heavily used I extracted it to be only compiled once close saadeghi#4372
|
@pdanpdan hi, may I ask what is blocking this to merge? |
Contributor
Author
|
I think holiday/free time. Be patient :) |
Owner
|
Will be merged soon 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
var(--until the first)varinvar(var(--a, var(--b)))[a-zA-Z0-9_-]+)varand(and between(and--close #4372
close #4408